Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 5:
(3 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/170ea941_3c8b0151
PS4, Line 12: core DEPRECATE gsmtap_inst_fd2()
wrong, not deprecating gsmtap_inst_fd2. […]
Done
File include/osmocom/core/gsmtap_util.h:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/71abc76d_2313647f
PS2, Line 30:
Alright... […]
Done
File src/core/libosmocore.map:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/b275ea45_45d0bda8
PS2, Line 42: gsmtap_inst_fd;
I have added `gsmtap_inst_fd` and `gsmtap_inst_fd2`
(the latter as deprecated) to libosmocore.map . […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 Oct 2023 13:21:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment