Attention is currently required from: dexter, laforge, lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/pysim/+/40468?usp=email )
Change subject: smdpp: less verbose by default
......................................................................
Patch Set 11:
(4 comments)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40468/comment/a6b29ec5_52efdc65?usp=em… :
PS6, Line 112: #print("Using nameConstraints parsing for variant O
certificate")
Should this debug? Or not could you drop the line?
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/353ab3c0_75e9a30d?usp=em… :
PS6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate
variant")
Should this debug? Or not could you drop the line?
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/cdcf06dd_b9df7316?usp=em… :
PS6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content))
logger. […]
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/662ef91a_bf689b6b?usp=em… :
PS6, Line 370: logger.debug("Tx JSON: %s" %
json.dumps(output)[:200])
Is this an expensive operations because the object is
huge (json.dumps)? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40468?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49
Gerrit-Change-Number: 40468
Gerrit-PatchSet: 11
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Jul 2025 15:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>