Attention is currently required from: dexter, laforge, lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email )
Change subject: smdpp: less verbose by default ......................................................................
Patch Set 11:
(4 comments)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40468/comment/a6b29ec5_52efdc65?usp=ema... : PS6, Line 112: #print("Using nameConstraints parsing for variant O certificate")
Should this debug? Or not could you drop the line?
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/353ab3c0_75e9a30d?usp=ema... : PS6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate variant")
Should this debug? Or not could you drop the line?
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/cdcf06dd_b9df7316?usp=ema... : PS6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content))
logger. […]
Done
https://gerrit.osmocom.org/c/pysim/+/40468/comment/662ef91a_bf689b6b?usp=ema... : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200])
Is this an expensive operations because the object is huge (json.dumps)? […]
Done