Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266 )
Change subject: bts: Proper tear down
......................................................................
Patch Set 1:
(2 comments)
File bts/BTS_Tests_OML.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/47979a12_daf9…
PS1, Line 155: friend
I think you want `private` instead of `friend` here, since this function is not used
anywhere outside of this module - no need to expose it.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/ad279ddf_2a20…
PS1, Line 155: f_shutdown_helper
We already have `f_shutdown()` in `library/Misc_Helpers.ttcn`, can we re-use it here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I761ae94aa698a74bb30b8a6b1860358545f222b5
Gerrit-Change-Number: 32266
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Apr 2023 13:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment