19 Jan
2023
19 Jan
'23
9:46 p.m.
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31019 )
Change subject: Introduce netdev API ......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8: Do we really need the "set address" in addition to the "add address"? I've always found it weird that we have one function using legacy BSD ioctl, and another function using netlink messages. And then there's add but not delete.
"ideally" there would be a shared implementation that can do both, and maybe even use libmnl rather than hand-crafting. libosmocore already depends on libmnl anyway.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31019
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ce8c37f7363e54cabd5972f7a0809e1e2d98ed
Gerrit-Change-Number: 31019
Gerrit-PatchSet: 8
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 19 Jan 2023 20:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment