Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email )
Change subject: IPA_Emulation.ttcn: Add call to support dis/enabling CCM management
......................................................................
Patch Set 2:
(1 comment)
File library/IPA_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471/comment/ef08d517_78c9…
:
PS2, Line 945: cfg_chg_ccm_enabled
Do you really need a local variable here? Why not
passing `g_ccm_enabled`?
No idea, but I prefer explicitly setting it through :=, it
becomes clear what it's doing and how the var can be modified.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40471?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If68e0ba36c3a56f021dd50aadf2156ddc696b816
Gerrit-Change-Number: 40471
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jun 2025 08:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>