Attention is currently required from: Hoernchen, dexter, jolly, laforge.
lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email )
Change subject: ccid_device: Reject XfrBlock with zero-length data
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
well, that is then how pcscd + the application deals with it, fine. […]
I don't have a strong opinion.
I'm fine with this patch. It is more a question, do we want to reject here 0 byte messages in the ccid layer?
And do we want to have a second patch which rejects messages < 5 in the iso_fsm_slot_xfr_block_async() as you do similar for messages > 260 in the next change/commit?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8
Gerrit-Change-Number: 42192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-CC: dexter
pmaier@sysmocom.de
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Feb 2026 16:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu
