Attention is currently required from: pespin, dexter. fixeria has uploaded a new patch set (#4) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30489 )
Change subject: llc: Proper separation of public & private APIs, Introduce llc_prim API ......................................................................
llc: Proper separation of public & private APIs, Introduce llc_prim API
Most of the existing (and added) data structures are kept private, since most of those don't really need to be used outside internal code in the library.
Most if not all the interaction from upper and lower layers towards LLC is now done through the new llc_prim pubic interface. This interface is based on 3GPP TS 44.064 section 7.1.2.
This commit also implements some of the code paths of the public API by means on importing LLC code from osmo-sgsn.git commit 57b63875c762a784127a13becd1c2549ca6c5454. The import of code cannot be done in a separate commit since existing code in osmo-sgsn.git is low quality and has tons of layer violations in all directions. Hence, this commit aims at being an initial point of having some working LLC stack by means of a few unit tests, but by no means aims to be a total working implementation. Some code paths are missing; bugs are expected at this point.
Related: OS#5502 Change-Id: I588eb576b2703262f4ab9566ec362920d8390cfd --- M include/osmocom/gprs/llc/Makefile.am M include/osmocom/gprs/llc/llc.h M include/osmocom/gprs/llc/llc_prim.h A include/osmocom/gprs/llc/llc_private.h M src/llc/Makefile.am A src/llc/llc.c A src/llc/llc_bssgp.c A src/llc/llc_grr.c A src/llc/llc_ll.c A src/llc/llc_llgmm.c M src/llc/llc_pdu.c M src/llc/llc_prim.c M src/llc/llc_xid.c M tests/llc/Makefile.am A tests/llc/llc_prim_test.c A tests/llc/llc_prim_test.err A tests/llc/llc_prim_test.ok M tests/llc/pdu_codec_test.c M tests/llc/pdu_codec_test.ok A tests/llc/xid_codec_test.c A tests/llc/xid_codec_test.err A tests/llc/xid_codec_test.ok M tests/testsuite.at 23 files changed, 2,805 insertions(+), 402 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/89/30489/4