Attention is currently required from: laforge, laforge.
daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email )
Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I looked at that, but the tag is a property of the (sub-)class and used in the metaclass: […]
I could also change the meta class __new__ to accept the {tag, comprehension} style and use that internally, but then we still need a way to control the comprehension bit in the constructor of the class.
--
To view, visit
https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I9ca689b9b51152f3907ea470c7b42a0b12208459
Gerrit-Change-Number: 42556
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@gnumonks.org
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@gnumonks.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Tue, 31 Mar 2026 09:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de