[S] Change in osmo-ttcn3-hacks[master]: library/GTPv1U_Templates: Mark parameters as templates

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email ) Change subject: library/GTPv1U_Templates: Mark parameters as templates ...................................................................... Patch Set 2: (4 comments) File library/GTPv1U_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/2b790366_1353… PS1, Line 58: template (value) It helps in easying the posibility to pass both values and template. This way also one doesn't need to be calling valueof() everytime it uses the template. After lots of cleanup of errors and use cases I find this the best approach: Keep using tmeplate parameters for parent template parameters, until an explicit value is required. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/5f62d481_c52e… PS1, Line 61: template (value) GTPU_IEs ies It doesn't cause a problem either, and allows for more freedom to the caller/user of the template. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/8d36a78c_cf7e… PS1, Line 122: valueof(ts_UEchoReqPDU I forgot these ones, I'm cleaning them up now. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645/comment/ae8c9bea_083d… PS1, Line 145: valueof(ip_addr) See my first comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I278f7dbc64704c1ba2b8a75d6f540ac52b067598 Gerrit-Change-Number: 37645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 08:42:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment