Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email )
Change subject: Use use new osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
Patch Set 1:
(1 comment)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39385/comment/b50daa86_bf8a9845?… :
PS1, Line 142: static int srvc_ipa_segmentation_cb2(struct osmo_stream_cli *cli, struct
msgb *msg)
: {
: return osmo_ipa_segmentation_cb(msg);
: }
:
@laforge@gnumonks.org While it involves a bit more
code I think it's totally fine. […]
yeah, let's un-deprecate the old API.
thanks.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I02c55179a144e3bbd1f760f5429e16c6e327111e
Gerrit-Change-Number: 39385
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 24 Jan 2025 10:00:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>