Attention is currently required from: neels, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/33095 )
Change subject: rlcmac: Implement UL TBF Countdown procedure
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/gprs/rlcmac/tbf_ul.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33095/comment/7d00c330_c77c246c
PS4, Line 45: countdown_procedure
drop this name? appears to not be used anywhere and
looks odd here.
ack, that's wrong :)
File src/rlcmac/llc_queue.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33095/comment/85a9040d_a24406f7
PS2, Line 234: /* TODO: for each array item (llist), llist_add (prepend) to the gre list
(passing ownseship of message) */
I guess this can be resolved now?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/33095
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If043c86a0c2b89d0ac0b8174de39fbcb22bed8cb
Gerrit-Change-Number: 33095
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 06 Jun 2023 10:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment