12 Jul
2023
12 Jul
'23
6:56 p.m.
Attention is currently required from: laforge, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33691 )
Change subject: split pySim/legacy/{cards,utils} from pySim/{cards,utils} ......................................................................
Patch Set 5: Code-Review-1
(2 comments)
Patchset:
PS5: * You're missing to add `__init__.py` to new submodules. * `setup.py` needs to be updated to include new submodules in `packages[]`.
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/33691/comment/a84dfc13_3d3fcb69 PS5, Line 85: EF.DIR But you're checking `DF.GSM` here. Looks like copy-paste?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/33691
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf831929730c48f90679a83d69049475cc5077
Gerrit-Change-Number: 33691
Gerrit-PatchSet: 5
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Jul 2023 16:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment