Attention is currently required from: lynxis lazus.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )
Change subject: Initial S6b support
......................................................................
Patch Set 2:
(2 comments)
File src/aaa_diameter_s6b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/c8c2408b_dc21…
PS2, Line 138: % APN is optional and should be []
old code?
Could be, I'm just submitting
initial code base to have something answering, we can clean up later once everything is in
place, with smaller incremental patches improving the code base.
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/80e3de58_54b8…
PS2, Line 148: SessionId = diameter:session_id(application:get_env(?ENV_APP_NAME,
origin_host, ?ENV_DEFAULT_ORIG_HOST)).
It looks you're missing something here.
Yes,
because AAA initiated procedures are not yet implemented here, only AAR+AAA initiated by
PGW. We can add missing procedures as follow up, I'm for now fosucing on adding
initial socket handling for each interface and implementing the minimum subset I need to
go forward in a single ttcn3 test.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 23 Oct 2023 14:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment