Attention is currently required from: fixeria, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645?usp=email )
Change subject: pfcp: implement sending Network Instance IEs ......................................................................
Patch Set 3:
(2 comments)
File src/osmo-hnbgw/ps_rab_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645/comment/6b8fb907_57222fca PS3, Line 202: #define set_netinst(NETINST_MEMBER, STRING) do { \
main reason for macro is that it works for both […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645/comment/1096fc71_acc2131b PS3, Line 244: set_netinst(ser->create_pdr[ser->create_pdr_count].pdi.network_inst, g_hnbgw->config.pfcp.netinst.core);
better than some macro which one for sure has to go look at when looking at the code because god kno […]
from my perspective, the confusing part is the deep DAG structure of PFCP, and it is less interesting to understand how the macro does what you mean. doing as i please now