Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30685 )
Change subject: osmo_stream_srv_link_close(): properly handle NULL input
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think library shouldn't suddenly crash it's
user due to omitted NULL-check. […]
In my experiencie this ends up people not caring
about what the hell is passed to functions and then ending up in a situation which nobody
knows anymore what is expected in there, nor it's easy to follow lifecycle of objects.
As said, if others are happy with this they are free to support merging this.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30685
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie15bb3dc99bfe18065e03fde68d517b0d389b7ad
Gerrit-Change-Number: 30685
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Dec 2022 17:00:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment