Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email )
Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/8233395f_659f9564?usp=... : PS1, Line 918: static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup, Since we have 2 inout pars and 1 in par, please move the in par to the end instead of having it in the middle.
https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/01263951_0f79eb8c?usp=... : PS1, Line 1008: rc = gsm48_cc_tx_setup_set_bearer_cap(trans, setup, &bearer_cap); (trans, &bearer_cap, setup)