Attention is currently required from: laforge, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 )
Change subject: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to
PacketCellChangeNotification
......................................................................
Patch Set 8:
(3 comments)
File library/RLCMAC_CSN1_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/29e1b35b_3cee…
PS7, Line 999: record of EutranCCNMeasReportItem
I recommend specifying the min/max length here: […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/215af94b_65fb…
PS7, Line 1001: uint7_t
It's defined as `bit (3)`, so `uint3_t`.
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/3a97c7e7_3469…
PS7, Line 1069: variant (eutran_target_cell) "PRESENCE(eutran_target_cell_presence
= '1'B)"
missing `PRESENCE` attribute for
`eutran_ccn_meas_rep`.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4
Gerrit-Change-Number: 32995
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Jun 2023 12:17:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment