Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32105 )
Change subject: lc15: fix compiler warning about unused variable cell_size
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bts-lc15/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32105/comment/e91b9128_f4002149
PS1, Line 1830: uint8_t cell_size = bts->max_ta << 2;
Not sure if this is a good idea. Generally it's not allowed to define variables in
switch cases, unless you have additional curly braces `case foo: { ... }`. This works in
gcc, but may not compile with clang... I suggest adding curly braces.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32105
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0bf1542f613f613d03609d50836137ff440401af
Gerrit-Change-Number: 32105
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 29 Mar 2023 09:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment