10 Jan
2025
10 Jan
'25
12:45 a.m.
Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email )
Change subject: osmo_iofd_register: fix the case of changing fd ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/13113700_83d7f1a3?u... : PS2, Line 759: if (fd >= 0) I think you don't even need this "if" line, you can do "iofd->fd = fd;" directly.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b
Gerrit-Change-Number: 39276
Gerrit-PatchSet: 2
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Comment-Date: Thu, 09 Jan 2025 23:45:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes