Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31578 )
Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
File include/osmocom/bsc/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/79f24e71_951b9e76
PS4, Line 280: pgroup
See my comment
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comments/669099fc_aa3e5889.
It's not a paging group but just the last three digits of IMSI, so it should be named
'imsi', and let's use `uint16_t` as Pau suggested.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31578
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id6acbd243adf26169e5e8319dd66bb68dd6a3c22
Gerrit-Change-Number: 31578
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Mar 2023 13:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment