Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email )
Change subject: logging: Make struct log_context and struct log_target private
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Indeed. […]
I am not strictly against breaking API at some point (ideally once, applying similar patches removing deprecated stuff). After all, there have been changes breaking old code in less obvious ways, like https://osmocom.org/issues/6728 (talloc parentship mess), so what's the point of ensuring that old code compiles given that it will just crash at run-time (referring to https://osmocom.org/issues/6728 again here).
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iecbd07995ccb465a44be0debcc97458b2b240a0e
Gerrit-Change-Number: 41891
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 20 Jan 2026 14:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de