Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages ......................................................................
Patch Set 3:
(1 comment)
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/e523903a_3aa... : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
I don't understant why it's so hard to first reformat the code, and then add your changes on top of […]
yes, really interesting, i wonder why that is? interestingly I rarely see any other developer even submitting any kind of "formatting first then changes" commits for review in the first place, maybe because no one touches those code parts with artisanal formatting that are impossible to modify without reformatting or adjusting the linter? Its really weird how I'm apaprently supposed to take shit for touching these parts, as usual.