Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26955 )
Change subject: ranap_common_ran: add decoder for CN/MSC originated messages ......................................................................
Patch Set 6:
(6 comments)
Patchset:
PS5:
I think they are rather critical, thanks for finding them!
Thanks for reviewing this.
File include/osmocom/ranap/ranap_common.h:
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/adddf1bf_971d785d PS5, Line 599: funktions
Tippfehler: functions
Done
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/53eece89_29e35e55 PS5, Line 90: unsuccessfulOutcome
successfulOutcome? I think it's not critical, given that 'procedureCode' is present in all union mem […]
Oh, thats indeed wrong.
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/b2a9c055_5a06f869 PS5, Line 102: unsuccessfulOutcome
outcome? I think it's not critical, given that 'procedureCode' is present in all union members at th […]
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/6afc7803_8b20c04e PS5, Line 124: unsuccessful
copy-paste: successful
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/26955/comment/6811ad06_5e934f42 PS5, Line 132: unsuccessful
Neither unsuccessful not successful, so this word should be removed.
Done