Attention is currently required from: fixeria, laforge, neels.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email )
Change subject: esim/http_json_api: allow URL rewriting ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/42274/comment/bc1b3125_cf12f0a0?usp=ema... : PS1, Line 15: reqrite_url
(typo)
Done
File pySim/esim/http_json_api.py:
https://gerrit.osmocom.org/c/pysim/+/42274/comment/c121aab3_6f575351?usp=ema... : PS1, Line 373: reqriting
(typo)
Done
https://gerrit.osmocom.org/c/pysim/+/42274/comment/759bb415_adf8ef87?usp=ema... : PS1, Line 391: data
maybe it would be good to complete composition of data before calling rewrite_url()? i mean, maybe r […]
We can move it below the line. I see no problems with that.