Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41396?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified-1 by Jenkins Builder
Change subject: ipa: Clarify msgb_free in ipa_rx_msg() ......................................................................
ipa: Clarify msgb_free in ipa_rx_msg()
First of all, clean up and clarify the handling of msgb in ipa_rx_msg_sccp() by always freeing the patched msgb copy, and letting parent function free the original received msgb.
This in turn allows moving the msgb_free() of the received msg to ipa_cli_read_cb() and ss7_asp_ipa_srv_conn_rx_cb(), which is where the msgb is allocated, and makes the msgb lifecycle far more easy to understand. This is also what's already done in the xua_cli_read_cb()/ss7_asp_xua_srv_conn_rx_cb(). This way we have similar code paths in xua and ipa.
Related: OS#6876 Change-Id: Id29955182d9da47165ee9a2d7777b92fb87844b9 --- M src/ipa.c M src/ss7_asp.c 2 files changed, 26 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/96/41396/2