[S] Change in osmo-bsc[master]: ctrl: Add cell reselection hysteresis control

matanp has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32515 ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ctrl: Add cell reselection hysteresis control ...................................................................... ctrl: Add cell reselection hysteresis control Change-Id: Ia96f6656d99381c039a4b3fd02674215fbbaec91 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 48 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index bd8a442..e087f8d 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -802,6 +802,44 @@ CTRL_CMD_DEFINE(bts_cell_reselection_penalty_time, "cell-reselection-penalty-time"); +static int verify_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + const int cell_reselection_hysteresis = atoi(value); + + if (cell_reselection_hysteresis < 0 || cell_reselection_hysteresis > 14) { + cmd->reply = "Value is out of range"; + return 1; + } else if (cell_reselection_hysteresis % 2 != 0) { + cmd->reply = "Value must be even"; + return 1; + } + + return 0; +} + +static int get_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + + cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_sel_par.cell_resel_hyst * 2); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} + +static int set_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + bts->si_common.cell_sel_par.cell_resel_hyst = atoi(cmd->value) / 2; + cmd->reply = "OK"; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE(bts_cell_reselection_hysteresis, "cell-reselection-hysteresis"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -826,6 +864,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_penalty_time); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_hysteresis); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia96f6656d99381c039a4b3fd02674215fbbaec91 Gerrit-Change-Number: 32515 Gerrit-PatchSet: 4 Gerrit-Owner: matanp &lt;matan1008(a)gmail.com&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: matanp &lt;matan1008(a)gmail.com&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged