Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email )
Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
......................................................................
Patch Set 1:
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/39829/comment/e19c083a_c9ae185a?usp… :
PS1, Line 2068: lchan->ta_ctrl.current = 0;
it's a bit of a question whether we expect all of those valuse to be zero or otherwise
sanely default-initialized when we start using a lchan or not. My preference would be to
re-set the ta_ctrl.current to zero during LCHAN release/deactivation.
If you want to do it here, then why are we not also setting ms_power_ctrl.{max,current} if
the RSL_IE_MS_POWER is not presetn? opr many other parts of this function...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2
Gerrit-Change-Number: 39829
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Mar 2025 08:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No