Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34133 )
Change subject: layer23: modem: Pass fn from lapdm to L1CTL-CCCH_DATA.ind
......................................................................
Patch Set 7:
(3 comments)
File src/host/layer23/src/modem/grr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/45e9b4ff_b746e2cb
PS6, Line 98: uint32_t fn = *(uint32_t *)(&msg->cb[0]);
also const like below?
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/e4703211_fb13b840
PS6, Line 210: FN=%u BCCH message (type=0x%02x)
Please move the `Fn=%u` inside the braces to have
consistent formatting: […]
Done
https://gerrit.osmocom.org/c/osmocom-bb/+/34133/comment/b5d881f2_e94d67f7
PS6, Line 381: memcpy
Doing `memcpy` is not really needed, right? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34133
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7a9f31ae363fe7de019ff1a906f3978ff3074036
Gerrit-Change-Number: 34133
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Aug 2023 12:00:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment