Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31972
)
Change subject: gsm_bts_check_ny1: Prevent possible division by zero
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31972/comment/9b702b9d_b2cf0d84
PS1, Line 1734: if (!(T3105 * ny1 > GSM_T3124_MAX + GSM_NY1_REQ_DELTA)) {
if Ny1 should always be higher than 0 (GSM_T3124_MAX + GSM_NY1_REQ_DELTA), then T3015
cannot be 0 here (at least it doesn't make sense it can be configured to 0).
Hence, rather than applyig this patch, I'd change the T_def row to have a min_val >
0, eg 1.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31972
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad
Gerrit-Change-Number: 31972
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Mar 2023 09:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment