Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )
Change subject: personalization: add param_source.py, implement batch personalization ......................................................................
Patch Set 8:
(3 comments)
File pySim/esim/saip/param_source.py:
https://gerrit.osmocom.org/c/pysim/+/40096/comment/770a282b_008ad68b?usp=ema... : PS3, Line 33: abstract
plug here the same conclusion i formed about the other is_abstract flag. […]
Done
https://gerrit.osmocom.org/c/pysim/+/40096/comment/8d6da696_1f0fd0b1?usp=ema... : PS3, Line 132: RandomDigitSource
ack
Done
https://gerrit.osmocom.org/c/pysim/+/40096/comment/41ec6dc4_2a00211f?usp=ema... : PS3, Line 133: 'incrementing sequence of digits'
(i never got over it, python used to be so single-quote-y, but at some point linters started making […]
Done