Attention is currently required from: daniel, fixeria.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email )
Change subject: Improve tests
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534/comment/1678024c_fab35a... :
PS1, Line 7: dynamically
linking it statically could also improve testin because the tests can use function which aren't expo […]
Yes, linking against the .a does link those statically, while keeping other dependencies dynamically afaik. That's how we are doing it everywhere afaict.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/41534?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I074f243b62a516534099c88f691a28065cd763dd
Gerrit-Change-Number: 41534
Gerrit-PatchSet: 2
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Wed, 03 Dec 2025 13:04:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu