Attention is currently required from: laforge, neels, osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email )
Change subject: pick up all *.vty in EXTRA_DIST
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
For the record, 'make dist' in osmo-bsc
includes all *.vty files as expected, so the wildcard Works For Me (TM)...
Personally, I am not strictly against using the wildcards. But as the above-mentioned
document states, there can be problems with portability. And there will likely be warnings
about that when running `autoreconf -fi`. If portability is not a concern for us (I guess
it's not, since we're primarily targeting GNU/Linux nowadays?), then let's use
them. The wildcards play well with the drop-in concept of the VTY test scripts.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259
Gerrit-Change-Number: 35872
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Feb 2024 15:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment