Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email )
Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md ......................................................................
Patch Set 5:
(2 comments)
File doc/manuals/chapters/cli.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/dcfbcd6c_6c1a1... : PS4, Line 34:
is so much verbosity useful? this all needs to be kept in sync with changes to the program
I see no problem here either. I do not expect the new command line arguments to be added often, and even if we have to, updating the user manual is not a big deal.
File doc/manuals/chapters/rest.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/0ee8031a_ba495... : PS4, Line 290: === Interactive CLI (`osmo-s1gw-cli`)
this was just added in the previous patch, not great for code review :\
I am just moving this block into a dedicated file that documents `osmo-s1gw-cli`. Not sure what's wrong here, but I've removed this section from previous patch to avoid confusion.