Attention is currently required from: pespin, dexter.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
......................................................................
Patch Set 16:
(2 comments)
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b2c936b1_c3f9a69d
PS16, Line 878: {
Ack
It's allocated with talloc_zero()
already.
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/7761728f_d5153f56
PS16, Line 44: $(LIBOSMOCORE_LIBS) \
I guess there is some conflict with LIBOSMOCRE_LIBS so
it had to be replaced?
It's not replaced, merely shifted together with other
libosmo* - I'll re-arrange to make diff look nicer.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 16
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Aug 2022 08:52:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment