fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/35788?usp=email )
Change subject: mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()
......................................................................
mobile: fix -Wmaybe-uninitialized in tch_csd_rx_{to,from}_l1()
It's unlikely to happen as long as all TCH_DATA_IOF_* variants are
handled in the switch statements, but still gcc does complain.
Change-Id: I0a81d5c4f11feb7cf73771c23848dee9ce6ec620
---
M src/host/layer23/src/mobile/tch_data.c
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/src/host/layer23/src/mobile/tch_data.c
b/src/host/layer23/src/mobile/tch_data.c
index c93c828..5474bdf 100644
--- a/src/host/layer23/src/mobile/tch_data.c
+++ b/src/host/layer23/src/mobile/tch_data.c
@@ -317,6 +317,10 @@
swap_words(msgb_l3(msg), msgb_l3len(msg));
osmo_pbit2ubit_ext(data, 0, msgb_l3(msg), 0, data_len, 1);
break;
+ default:
+ LOGP(DCSD, LOGL_FATAL,
+ "%s(): unhandled data I/O format\n", __func__);
+ OSMO_ASSERT(0);
}
for (unsigned int i = 0; i < desc->num_blocks; i++) {
@@ -397,6 +401,10 @@
/* ... with swapped words (LE ordering) */
swap_words(msgb_l2(nmsg), msgb_l2len(nmsg));
break;
+ default:
+ LOGP(DCSD, LOGL_FATAL,
+ "%s(): unhandled data I/O format\n", __func__);
+ OSMO_ASSERT(0);
}
return gsm48_rr_tx_traffic(ms, nmsg);
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/35788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I0a81d5c4f11feb7cf73771c23848dee9ce6ec620
Gerrit-Change-Number: 35788
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged