28 Feb
2024
28 Feb
'24
6:24 p.m.
Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36095?usp=email )
Change subject: ipa_proto.erl: Implement TCP/IPA reassembly ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2: Would be nice to have some unit test coverage for this. Not blocking though.
File src/ipa_proto.erl:
https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36095/comment/de67f94a_5f9237... PS2, Line 189: need_more_data -> {ok, Data}; cosmetic: please fix formatting here (nesting inside `case-of`)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36095?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_ss7
Gerrit-Branch: master
Gerrit-Change-Id: I322e6ab9368ad66be66a9e8d113575f51f9c91c3
Gerrit-Change-Number: 36095
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 28 Feb 2024 17:24:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment