Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27508 )
Change subject: gsm48_make_ho_cmd(): optionally add Synchronization Indication IE
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/gsm_04_08_rr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27508/comment/fece5c93_a50b1f3f
PS1, Line 562: if (!async || ho_scope & HO_INTER_BSC_IN) {
The last sentence "If ommited, ..." is not
really clear imho, what is omitted?
The whole paragraph/comment is about optional Synchronization Indication IE, so it applies
to this IE. There is nothing else that can be omitted in this context.
ack: please parenthesis around the & operation
Done.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27508
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4e5b1163a71443d706f14ce4bfd5c2294c320432
Gerrit-Change-Number: 27508
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Mar 2022 11:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment