Attention is currently required from: msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str_from_sockaddr2() ......................................................................
Patch Set 4:
(2 comments)
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/76558c6b_76811d3f PS4, Line 380: { as far as I can see the guess is the only difference. Maybe the api doc can reflect that. Also or maybe update the existing function so that it is able to guess?
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/90c5cc31_a578bec7 PS4, Line 385: the guess above dereferences src, in the case where src == NULL, the function would have crashed already.