Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194 )
Change subject: PCUIF: use confirmation flag in struct gsm_pcu_if_pch
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Same as I said on the other patch: I'm not liking this approach. Keep the BTS/BSC
decoding the message type to know what to do with it, and let the "confirm"
variable be simply a bool on whether the BSC answers to the PCU when it
schedules/transmits it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34194
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7017ca20ca7e0b77d0f363121e4f17280e39e8ac
Gerrit-Change-Number: 34194
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Aug 2023 14:00:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment