[M] Change in osmo-bts[master]: common+trx: make uplink ECU optional

Attention is currently required from: falconia, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 ) Change subject: common+trx: make uplink ECU optional ...................................................................... Patch Set 4: (3 comments) File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/4ec1ddfd_3be4fd4a PS4, Line 809: bts->suppress_ul_ecu = false; I find it weird that you are kinda changing the boolean logic with the VTY command when using the variable "suppress_ul_ecu". In general I'd be more in favour of having an affirmative boolean "use_ul_ecu" which is set to true here and to false below. File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/43bfc1de_cd645c19 PS4, Line 445: if (!trx->bts->suppress_ul_ecu) if (trx->bts->use_ul_ecu) https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/ab0d207e_7945408a PS4, Line 481: if (!trx->bts->suppress_ul_ecu) if (trx->bts->use_ul_ecu) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e Gerrit-Change-Number: 32110 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 15 May 2023 11:39:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment