Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )
Change subject: Add LLC and HLC transcoding to MNCC transcoding functions
......................................................................
Patch Set 3:
(2 comments)
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/ee3c19c8_2b9ee687
PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */
You are right, I simplified the functions by removing the 'local buffer'. […]
Done
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/933e2e27_548ccf9c
PS2, Line 413: gsm48_encode_highl_compat
The `encode`/`decode` in symbol names creates a false impression that these functions actually `enco […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de
Gerrit-Change-Number: 35391
Gerrit-PatchSet: 3
Gerrit-Owner: jolly
andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 04 Jan 2024 15:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
