Attention is currently required from: laforge, neels.
falconia has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email )
Change subject: build config: add --disable-ortp option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
hmm, except, do we now need to update the build system
to ensure that this option builds successfully?
I am not asking Osmocom core team to test builds with this new option. **I** will be
making a lot of builds with --disable-ortp, and if it breaks in the future, I will be the
one to raise the alert and fix it.
Might reconsider the effort:benefit ratio...?
What effort? I am not asking your team to add the new build variant to your CI, just merge
the patch (providing the option) so I don't have to keep reapplying it to every new
release and every sandbox build I do.
With the two +1's from you and @osmith@sysmocom.de I can now merge the patch - but
I'll give it another few days for further review.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/36975?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I554260483b94d812ac3a957c969a902870f53883
Gerrit-Change-Number: 36975
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 01:21:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment