Attention is currently required from: fixeria, msuraev.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31299 )
Change subject: socket: propagate error in osmo_sock_unix_init() to the caller
......................................................................
Patch Set 2:
(2 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/49812fc3_4e563c93
PS1, Line 1422: return -1;
Removing this looks unrelated. […]
agree
possibly need to do more of rc = -errno above, connect() and bind() manpages should tell
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/e1b8fde0_e3a11fe6
PS2, Line 1401: close(sfd);
rather keep the 'goto err', instead of duplicating the exit-cleanup code
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31299
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia90d2ca3106b58dc5953d930f13df829d5b6966f
Gerrit-Change-Number: 31299
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 01:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment