fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30306 )
Change subject: fixup: firmware/layer1: introduce experimental PDCH support ......................................................................
fixup: firmware/layer1: introduce experimental PDCH support
This regression was introduced with the experimental PDCH support back in 2020. In particular, I made a mistake in the l1s_nb_resp() resetting rxnb.dl->link_id to 0x00 if MF_F_PTCCH is not set, which is of course not set for non-PDCH channels.
Change-Id: I8593f9b001e669e7cd10cc42c05221a6037e8ae1 Fixes: 67c49ba664f7d7d7f07986a20e6d6363a27e3fc4 Fixes: OS#5791, OS#5133 --- M src/target/firmware/layer1/prim_rx_nb.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/30306/1
diff --git a/src/target/firmware/layer1/prim_rx_nb.c b/src/target/firmware/layer1/prim_rx_nb.c index 9656cf9..d6dd82a 100644 --- a/src/target/firmware/layer1/prim_rx_nb.c +++ b/src/target/firmware/layer1/prim_rx_nb.c @@ -122,7 +122,7 @@ /* Set SACCH indication in Link IDentifier */ if (mf_task_flags & MF_F_SACCH) rxnb.dl->link_id = 0x40; - if (mf_task_flags & MF_F_PTCCH) + else if (mf_task_flags & MF_F_PTCCH) rxnb.dl->link_id = 0x80; else rxnb.dl->link_id = 0x00;