Attention is currently required from: falconia, fixeria, neels.
nt2mku has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported ......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/901fd734_2bb085b8 PS7, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present.
The logic of the patch is correct, as we now know thanks to @vyanitskiy@sysmocom. […]
Done
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/3c589f4f_f7ec6a0b PS7, Line 322: int encode_3a = 0;
Make this bool instead of int?
Done
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/a5aa362a_3857a23b PS7, Line 340: encode_3a == 1
If encode_3a is changed to bool, then this check should take the bool directly, without == operator.
Done