Change in osmo-bsc[2021q4]: bssmap_reset: make T4 user configurable

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27091 ) Change subject: bssmap_reset: make T4 user configurable ...................................................................... bssmap_reset: make T4 user configurable The timer (T4) that controls the re-sending of the BSSMAP RESET can not be changed via the VTY, althrough it is defined via a tdef struct. Lets add a description along with default values to make it configurable via the VTY. Change-Id: I1fb5699220ab8a643a168567a89c6f381fe433a7 Related: SYS#5796 --- M src/osmo-bsc/bssmap_reset.c M src/osmo-bsc/net_init.c M tests/timer.vty 3 files changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bssmap_reset.c b/src/osmo-bsc/bssmap_reset.c index beb8968..4d24c01 100644 --- a/src/osmo-bsc/bssmap_reset.c +++ b/src/osmo-bsc/bssmap_reset.c @@ -47,7 +47,7 @@ osmo_tdef_fsm_inst_state_chg(FI, STATE, \ bssmap_reset_timeouts, \ (bsc_gsmnet)->T_defs, \ - 5) + -1) struct bssmap_reset *bssmap_reset_alloc(void *ctx, const char *label, const struct bssmap_reset_cfg *cfg) { diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index ec2f881..adcffc7 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -27,6 +27,7 @@ #include <osmocom/bsc/neighbor_ident.h> static struct osmo_tdef gsm_network_T_defs[] = { + { .T=4, .default_val=5, .desc="Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC" }, { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" }, { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" }, { .T=10, .default_val=6, .desc="RR Assignment" }, diff --git a/tests/timer.vty b/tests/timer.vty index 12c13ad..e832070 100644 --- a/tests/timer.vty +++ b/tests/timer.vty @@ -1,6 +1,7 @@ OsmoBSC> enable OsmoBSC# show timer +net: T4 = 5 s Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC (default: 5 s) net: T7 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout (default: 10 s) net: T8 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout (default: 10 s) net: T10 = 6 s RR Assignment (default: 6 s) @@ -53,6 +54,7 @@ OsmoBSC# configure terminal OsmoBSC(config)# network OsmoBSC(config-net)# timer +net: T4 = 5 s Timeout to receive BSSMAP RESET ACKNOWLEDGE from the MSC (default: 5 s) net: T7 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout (default: 10 s) net: T8 = 10 s inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout (default: 10 s) net: T10 = 6 s RR Assignment (default: 6 s) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2021q4 Gerrit-Change-Id: I1fb5699220ab8a643a168567a89c6f381fe433a7 Gerrit-Change-Number: 27091 Gerrit-PatchSet: 1 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged