Attention is currently required from: laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35232?usp=email )
Change subject: socket: Reimplement osmo_sock_init2_multiaddr() ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Patchset:
PS3: re-applying previous 1+1 after comment fix
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/35232/comment/7a4070cf_38760574 PS2, Line 933: * Both are checked here through "or" here to account for "bind flag set,
I'm talking about OSMO_SOCK_F_BIND or OSMO_SOCK_F_CONNECT flags here. […]
Ack, now it makes sense.
https://gerrit.osmocom.org/c/libosmocore/+/35232/comment/9e98c74d_f0bf49fc PS2, Line 945: (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) {
I thought about it, but in the end writing it this way is the easiest way of writing it, instead of […]
Okay