Attention is currently required from: laforge, pespin.

Patch set 3:Code-Review +2

View Change

3 comments:

• Patchset:

  • Patch Set #3:

    re-applying previous 1+1 after comment fix

• File src/core/socket.c:

  • Patch Set #2, Line 933: * Both are checked here through "or" here to account for "bind flag set,

    I'm talking about OSMO_SOCK_F_BIND or OSMO_SOCK_F_CONNECT flags here. […]

    Ack, now it makes sense.

  • Patch Set #2, Line 945: (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) {

    I thought about it, but in the end writing it this way is the easiest way of writing it, instead of […]

    Okay

To view, visit change 35232. To unsubscribe, or for help writing mail filters, visit settings.