Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31303 )
Change subject: Includes: Add gprs/rlc related enums
......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/gprs/gprs_bssgp.h:
https://gerrit.osmocom.org/c/libosmocore/+/31303/comment/807edfda_eea97a8c
PS4, Line 205: /* BSSGP procedure timing - timers and related counters (TS 101 343 v8.12.0
section 12.1)
Ah thanks I'll update it. […]
AFAIC first
ETSI managed the releases, and afterwards they were transferred to 3GPP. So always try to
use 3GPP numbering if possible.
File include/osmocom/gprs/gprs_rlc.h:
https://gerrit.osmocom.org/c/libosmocore/+/31303/comment/f1965f4f_93095412
PS1, Line 47: enum gprs_rlc_par {
libosmo-abis/inlude/osmocom/abis/ipaccess. […]
Please check which similar fields/enums are used when encoding the msg transmitted
into the wire, and find where they are defined, that's probably where you want them.
i guess those are transmitted over Abis OML, aka TS 12.21, and Probably
libosmocore/osmocom/gsm/protocol/gsm_12_21.h?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31303
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c
Gerrit-Change-Number: 31303
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Feb 2023 13:15:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment