Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39468?usp=email )
Change subject: gtplab-sysmo2025: Initial tunend test setup ......................................................................
Patch Set 7: Code-Review+1
(4 comments)
File testsuites/gtplab-sysmo2025/tunend/README.md:
https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/aebf2a69_d1d0c055... : PS7, Line 2: towards UPF on its 1st iface and which which should be sent back decapsulated (tunend) towards CN and received at TRex 2nd interface. wrap this line?
https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/f1805385_bef0320b... : PS7, Line 14: ---- Use ``` instead of --- to make a markdown code block
File testsuites/gtplab-sysmo2025/tunend/trex/gtpu_topo.py:
https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/7cd02e10_3bc9a88c... : PS7, Line 17: return ".".join(li) add a new line afterwards? (or two as in PEP-8)
File testsuites/gtplab-sysmo2025/tunend/upf/osmo-upf/configure.sh:
https://gerrit.osmocom.org/c/upf-benchmark/+/39468/comment/e0fd1541_499fe77c... : PS7, Line 34: sudo ip addr add 172.16.32.1/24 dev $IFACE_RAN || true; ; is not needed at the end of these lines (same below)